Hi Marek,

Thank you for the patch.

On Sun, Mar 17, 2024 at 07:16:31AM +0100, Marek Vasut wrote:
> Move the variable below comment which explains what the variable means.
> Update the comment. No functional change.
> 
> Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>
> ---
> Cc: Heinrich Schuchardt <xypron.g...@gmx.de>
> Cc: Kuninori Morimoto <kuninori.morimoto...@renesas.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Tom Rini <tr...@konsulko.com>
> ---
>  boot/image-fdt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/boot/image-fdt.c b/boot/image-fdt.c
> index c37442c9130..16cd15e7e44 100644
> --- a/boot/image-fdt.c
> +++ b/boot/image-fdt.c
> @@ -218,12 +218,12 @@ int boot_relocate_fdt(struct lmb *lmb, char 
> **of_flat_tree, ulong *of_size)
>                       if (start + size < low)
>                               continue;
>  
> -                     usable = min(start + size, low + mapsize);
> -
>                       /*
>                        * At least part of this DRAM bank is usable, try
> -                      * using it for LMB allocation.
> +                      * using the the DRAM bank up to $usable address

s/the the/the/

Is it a u-boot convention to write $variable to refer to a variable in
comments ?

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> +                      * limit for LMB allocation.
>                        */
> +                     usable = min(start + size, low + mapsize);
>                       addr = lmb_alloc_base(lmb, of_len, 0x1000, usable);
>                       of_start = map_sysmem(addr, of_len);
>                       /* Allocation succeeded, use this block. */

-- 
Regards,

Laurent Pinchart

Reply via email to