On Thu, Apr 7, 2011 at 10:13 AM, Andy Fleming wrote:
> On Apr 6, 2011, at 7:07 AM, Detlev Zundel wrote:
>>> This second version cleans up all checkpatch errors that I reasonably could,
>>> and addresses most of the comments from the first round of reviews.
>>
>> WARNING: Use of volatile is usually wrong: see
>> Documentation/volatile-considered-harmful.txt
>> #1299: FILE: drivers/net/tsec.c:1740:
>> +static int tsec_send(struct eth_device *dev, volatile void *packet, int
>> length)
>>
>> Ah I see. This is needed because include/net.h prescribes this as the
>> interface. Oh well, we should clean this up at some later point, so
>> it's ok from my perspective to ignore this and at least stay consistent.
>>
>> WARNING: do not add new typedefs
>> #4271: FILE: include/phy.h:389:
>> +typedef enum {
>>
>> I know that we have lots of typedefs, but we should not add new ones.
>> Actually not using this typedef for an enum-type would make the sources
>> easier for me to read as I don't have to do this extra lookup step.
>
> True, but this typedef is in Linux the same way. It seemed sensible to keep
> them the same
agreed. fwiw :p.
-mike
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
