Re: [PATCH v3] board: rockchip: add Rockchip Toybrick TB-RK3588X board

[Dan Carpenter]

On Tue, Mar 05, 2024 at 09:29:22AM +0800, zhangzj wrote:
> +
> +#ifdef CONFIG_OF_BOARD_SETUP
> +static int rk3588_add_reserved_memory_fdt_nodes(void *new_blob)
> +{
> +     struct fdt_memory gap1 = {
> +             .start = 0x3fc000000,
> +             .end = 0x3fc4fffff,
> +     };
> +     struct fdt_memory gap2 = {
> +             .start = 0x3fff00000,
> +             .end = 0x3ffffffff,
> +     };
> +     unsigned long flags = FDTDEC_RESERVED_MEMORY_NO_MAP;
> +     unsigned int ret;

"ret" should be int.  This doesn't affect runtime at all though.
#nitpicking

regards,
dan carpenter

> +
> +     /*
> +      * Inject the reserved-memory nodes into the DTS
> +      */
> +     ret = fdtdec_add_reserved_memory(new_blob, "gap1", &gap1,  NULL, 0,
> +                                      NULL, flags);
> +     if (ret)
> +             return ret;
> +
> +     return fdtdec_add_reserved_memory(new_blob, "gap2", &gap2,  NULL, 0,
> +                                       NULL, flags);
> +}