On Wed, Feb 21, 2024 at 11:57:51AM +0530, Sumit Garg wrote: > On Tue, 20 Feb 2024 at 21:02, Marek Vasut <ma...@denx.de> wrote: > > On 2/20/24 14:10, Sumit Garg wrote: > > > Also, enable reset driver which is a prerequisite for PCIe support. > > Commit message needs to be fixed. > > Let me reiterate the header here too. > > Enable PCIe/NVMe support. Also, enable the reset driver which > is a prerequisite for PCIe support.
With the commit message improved .. On Wed, Feb 21, 2024 at 11:59:10AM +0530, Sumit Garg wrote: > On Tue, 20 Feb 2024 at 21:34, Fabio Estevam <feste...@gmail.com> wrote: > > On Tue, Feb 20, 2024 at 10:51 AM Sumit Garg <sumit.g...@linaro.org> wrote: > > > diff --git a/configs/verdin-imx8mp_defconfig > > > b/configs/verdin-imx8mp_defconfig > > > index 22b8a334dfa..d8bd644322b 100644 > > > --- a/configs/verdin-imx8mp_defconfig > > > +++ b/configs/verdin-imx8mp_defconfig > > > @@ -185,3 +185,12 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 > > > CONFIG_USB_GADGET_PRODUCT_NUM=0x4000 > > > CONFIG_IMX_WATCHDOG=y > > > CONFIG_HEXDUMP=y > > > +CONFIG_DM_RESET=y > > > +CONFIG_RESET_IMX=y > > > +CONFIG_PCI=y > > > +CONFIG_PCIE_DW_IMX8=y > > > +CONFIG_PHY_IMX8M_PCIE=y > > > +CONFIG_CMD_PCI=y > > > +CONFIG_NVME=y > > > +CONFIG_NVME_PCI=y > > > +CONFIG_CMD_NVME=y > > > > Please don't group all these new config options at the end of the file. > That sounds better, I will do that for v2. ... and this change, feel free to add in v2 Acked-by: Francesco Dolcini <francesco.dolc...@toradex.com> Francesco
