On Tue, Jan 30, 2024 at 02:05:02PM +0000, Caleb Connolly wrote:
> @@ -119,6 +120,26 @@ static int ehci_usb_of_to_plat(struct udevice *dev)
> return 0;
> }
>
> +static int ehci_usb_of_bind(struct udevice *dev)
> +{
> + ofnode ulpi_node = ofnode_first_subnode(dev_ofnode(dev));
> + ofnode phy_node;
> +
> + if (!ofnode_valid(ulpi_node))
> + return 0;
> +
> + phy_node = ofnode_first_subnode(ulpi_node);
> + if (!ofnode_valid(phy_node)) {
> + printf("%s: ulpi subnode with no phy\n", __func__);
> + return -ENOENT;
> + }
> +
> + return device_bind_driver_to_node(dev, "msm8916_usbphy",
> "msm8916_usbphy",
> + phy_node, NULL);
> +
> + return 0;
Delete the extra return 0.
> +}
regards,
dan carpenter
