Hi Tom, On Mon, 15 Jan 2024 at 09:57, Raymond Mao <raymond....@linaro.org> wrote:
> Hi Tom, > > On Sat, 13 Jan 2024 at 10:27, Tom Rini <tr...@konsulko.com> wrote: > >> On Fri, Jan 12, 2024 at 01:33:34PM -0800, Raymond Mao wrote: >> >> > Get device tree from a bloblist if it exists. >> > If not, fallback to traditional way. >> > >> > Signed-off-by: Raymond Mao <raymond....@linaro.org> >> > --- >> > Changes in v2 >> > - Refactor of board_fdt_blob_setup(). >> > Changes in v4 >> > - Move the logics from board custom function to fdt library. >> > Changes in V5 >> > - Rebase the changes on top of master. >> > >> > lib/fdtdec.c | 18 +++++++++--------- >> > 1 file changed, 9 insertions(+), 9 deletions(-) >> >> Why was this just not dropped after: >> commit 70fe23859437ffe4efe0793423937d8b78ebf9d6 >> > In commit 70fe23859437ffe4efe0793423937d8b78ebf9d6, the FDT from bloblist > is always overridden when OF_BOARD is enabled (OF_BOARD is enabled when > OF_HAS_PRIOR_STAGE is on). I think this is not what we want. > The FDT from the bloblist passed from the previous stage should be the > default setting. > > If we want to build with OF_HAS_PRIOR_STAGE=y and without OF_BOARD to avoid the FDT from bloblist not being overridden, `imply OF_HAS_PRIOR_STAGE` needs to be dropped from Kconfig for ARCH_QEMU, otherwise check-of.sh will always complain. Do you mind me adding a patch to arch/arm/Kconfig? And then we can drop [PATCH v5 8/8]. [...] Thanks and regards, Raymond >
