Hello Kim, Kim Phillips wrote: > On Mon, 21 Mar 2011 08:01:57 +0100 > Heiko Schocher <h...@denx.de> wrote: > >> Signed-off-by: Heiko Schocher <h...@denx.de> >> cc: Kim Phillips <kim.phill...@freescale.com> >> cc: Holger Brunck <holger.bru...@keymile.com> >> cc: Wolfgang Denk <w...@denx.de> >> cc: Detlev Zundel <d...@denx.de> >> cc: Valentin Longchamp <valentin.longch...@keymile.com> >> --- > > Hi Heiko, sorry for the late review, but I must admit it doesn't help > the reviewer at all when later patches in a patchseries modify things > added by earlier patches in the same patchseries!
Sorry for that, I know, it is a big patchset ... >> include/mpc83xx.h | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/include/mpc83xx.h b/include/mpc83xx.h >> index ea137c7..e1b0929 100644 >> --- a/include/mpc83xx.h >> +++ b/include/mpc83xx.h >> @@ -1274,6 +1274,12 @@ struct pci_region; >> void mpc83xx_pci_init(int num_buses, struct pci_region **reg); >> void mpc83xx_pcislave_unlock(int bus); >> void mpc83xx_pcie_init(int num_buses, struct pci_region **reg); >> + >> +void disable_addr_trans(void); >> +void enable_addr_trans(void); >> +#if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER) >> +void ddr_enable_ecc(unsigned int dram_size); >> +#endif > > I don't believe these prototypes belong in mpc83xx.h - they're really > not 83xx-specific - e.g., 74xx and 85xx have identical names for > functions that have the same...function. > > Looking around I think the best place for them would be the 'start.S' > section of include/common.h. Feel free to protect with 83xx ifdefs; > others can add their platforms as necessary. Hmm.. I thought of this too, but that will result in adding ifdefs. (and special this file has a lot of ifdefs, so I wanted to prevent another ifdef mess...). But I can of course move it to include/common.h if thats the preferred place ... ? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
