Hi,

I just noticed this patch being pulled. Won't this break existing scripts though? I mean, I'm all for the change, as now I don't have to cut "pkcs11:" from URLs anymore, but it's bound to mess up some automation systems.

Ayoub Zaki wrote:
>            else
>                    snprintf(key_id, sizeof(key_id),
> -                           "pkcs11:object=%s;type=public",
> +                           "object=%s;type=public",
>                             name);

This is incorrect, now there's no "pkcs11:" at the start of the URL we pass to OpenSSL at all! Same with the similar clause in `rsa_engine_get_priv_key()`.

Bence

Reply via email to