Hi Tom, On Wed, 3 Jan 2024 at 14:08, Tom Rini <tr...@konsulko.com> wrote:
> On Tue, Jan 02, 2024 at 02:12:29PM -0800, Raymond Mao wrote: > > > Save boot arguments r[0-3] into an array for handover of bloblist from > > previous boot stage. > > > > Signed-off-by: Raymond Mao <raymond....@linaro.org> > > --- > > Changes in v2 > > - New patch file created for v2. > > Changes in v3 > > - Swap value of r0 with r2. > > Changes in v4 > > - Fix a bug when saving the boot args. > > > > arch/arm/cpu/armv7/start.S | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > So on platforms with SAVE_PREV_BL_INITRAMFS_START_ADDR / > SAVE_PREV_BL_FDT_ADDR we have this same logic, but in C, and it's > working and fine, given what we do. So could we not follow the example > of arch/arm/lib/save_prev_bl_data.c and have > arch/arm/lib/bloblist.c and have just one implementation for arm32/64? > > I went through arch/arm/lib/save_prev_bl_data.c, it looks that this patch is more straightforward and clean for working together with arch/arm/lib/bloblist.c to support arm FW Handoff spec. [...] Thanks and regards, Raymond
