Hi Wolfgang, On Wed, Mar 30, 2011 at 3:51 AM, Wolfgang Denk <w...@denx.de> wrote: > Dear Po-Yu Chuang, > > In message <1301402371-8697-1-git-send-email...@denx.de> I wrote: >> Commit 44c6e65 "rename _end to __bss_end__ broke building of a large >> number of systems (at least all PowerPC?): >> >> libstubs.o: In function `app_startup': >> examples/standalone/stubs.c:197: undefined reference to `__bss_end__' >> >> The rename should not be done for the files in the >> examples/standalone/ directory, as these are not using the code from >> start.S, but do their own BSS clearing, and either use their own >> linker scripts or the ones provided by the compilers. >> >> Signed-off-by: Wolfgang Denk <w...@denx.de> >> --- >> V2: Instead of messing with linker defines, revert the patch in >> question for the files in examples/standalone/ as suggested by >> Albert Aribaud. (Thanks!) > > Only now I realize that you submitted the very same patch before. > Stupid me. > > Does that mean that we have an agreement that this hould be the fix > then? If yes, I would like to pull this in (Po-Yu Chuang's patch, > that is). > > Do you agree?
Your commit message is better. Please just use your v2 as is. :-) Thanks, Po-Yu Chuang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
