On 16:06-20231221, Tom Rini wrote: > On Mon, Dec 11, 2023 at 04:12:09PM +0530, Siddharth Vadapalli wrote: > > > From: Manorit Chawdhry <m-chawd...@ti.com> > > > > The main_cpsw0_qsgmii_phyinit command is defined only for certain TI > > SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set. > > > > Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run > > only for such SoCs. > > > > Signed-off-by: Manorit Chawdhry <m-chawd...@ti.com> > > Signed-off-by: Siddharth Vadapalli <s-vadapa...@ti.com> > > Reviewed-by: Tom Rini <tr...@konsulko.com> > > Reviewed-by: Mattijs Korpershoek <mkorpersh...@baylibre.com> > > Applied to u-boot/next, thanks!
Shouldn't main_cpsw0_qsgmii_phyinit be part of the driver?? why are we scripting up driver initialization? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
