Hi Michal, On Wed, 20 Dec 2023 at 11:41, Michal Simek <michal.si...@amd.com> wrote:
> Hi Raymond, > > On 12/20/23 15:53, Raymond Mao wrote: > > Hi Michal, > > > > please avoid top posting. > > > Other vendors should add their own custom function under the > > "./board/<board-name>" directory. > > The inline function here is just to avoid the building errors on other > platforms > > which do not yet implement the custom function. > > Otherwise we have to create a function "board_bloblist_from_boot_arg()" > under > > all boards with this patch. > > pretty much platforms which enables bloblist via Kconfig want to start to > use > this functionality and start to get information out of it. > It means I think dependency is on BLOBLIST. Simon is using it for sandbox > that's > why I can understand that you want to limit it to ARM or ARM64 or both. > But I don't think you should connect it to any specific ARM arch like > ARCH_QEMU. > The reason I have to limit it with ARCH_QEMU in this patch is due to the fact that currently only board "qemu-arm" has implemented the required platform custom function "board_bloblist_from_boot_arg()". We can remove this limit and make it depend on the BLOBLIST only when all arm boards implement the required function. But at least now, with this patch, we need it under ARCH_QEMU, otherwise we will have linking errors when BLOBLIST is enabled on a board which is not "qemu-arm". For the future, I agree, this only depends on ARM, BLOBLIST and OF_BOARD. Thanks and regards, Raymond
