On Tue, 5 Dec 2023 at 06:47, Caleb Connolly <caleb.conno...@linaro.org> wrote: > > priv->pid is uint32_t, but dev_read_addr() returns a uint64_t on arm64, > with the upper bits being used for error codes. Do error checking before > downcasting to u32 to prevent errors being silently ignored. > > Reviewed-by: Sumit Garg <sumit.g...@linaro.org> > Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org> > Tested-by: Sumit Garg <sumit.g...@linaro.org> > Signed-off-by: Caleb Connolly <caleb.conno...@linaro.org> > --- > drivers/gpio/qcom_pmic_gpio.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass <s...@chromium.org>