On Mon, 4 Dec 2023 at 18:25, Raymond Mao <raymond....@linaro.org> wrote: > > Hi Ilias, > > BLOBLISTT_AREA_ARM is now holding the ones we already defined in the FW > Handoff spec for TF-A project only. > The TPM eventlog related ones are undefined in the spec yet, they stay in the > group BLOBLISTT_AREA_FIRMWARE.
We did define them past 0.9 [0]. So I think we should add them regardless. They are part of the main doc now [1] [0] https://github.com/FirmwareHandoff/firmware_handoff/pull/16/files [1] https://github.com/FirmwareHandoff/firmware_handoff/blob/main/source/transfer_list.rst#tpm-event-log-table-entry-layout-xferlist_evlog Regards /Ilias > > > /* BLOBLISTT_AREA_FIRMWARE */ > >- { BLOBLISTT_ACPI_GNVS, "ACPI GNVS" }, > >- { BLOBLISTT_INTEL_VBT, "Intel Video-BIOS table" }, > > { BLOBLISTT_TPM2_TCG_LOG, "TPM v2 log space" }, > > { BLOBLISTT_TCPA_LOG, "TPM log space" }, > >- { BLOBLISTT_ACPI_TABLES, "ACPI tables for x86" }, > >+ { BLOBLISTT_ACPI_GNVS, "ACPI GNVS" }, > > Thanks and regards, > Raymond > > On Mon, 4 Dec 2023 at 03:25, Ilias Apalodimas <ilias.apalodi...@linaro.org> > wrote: >> >> Hi all, >> >> [...] >> >> > common/bloblist.c | 16 +++++++++--- >> > include/bloblist.h | 65 ++++++++++++++++++++++++---------------------- >> > test/bloblist.c | 4 +-- >> > 3 files changed, 48 insertions(+), 37 deletions(-) >> > >> > diff --git a/common/bloblist.c b/common/bloblist.c >> > index a22f6c12b0..349ceddea5 100644 >> > --- a/common/bloblist.c >> > +++ b/common/bloblist.c >> > @@ -36,16 +36,24 @@ static struct tag_name { >> > enum bloblist_tag_t tag; >> > const char *name; >> > } tag_name[] = { >> > - { BLOBLISTT_NONE, "(none)" }, >> > + { BLOBLISTT_VOID, "(void)" }, >> > >> > /* BLOBLISTT_AREA_FIRMWARE_TOP */ >> > + { BLOBLISTT_CONTROL_FDT, "Control FDT" }, >> > + { BLOBLISTT_HOB_BLOCK, "HOB block" }, >> > + { BLOBLISTT_HOB_LIST, "HOB list" }, >> > + { BLOBLISTT_ACPI_TABLES, "ACPI tables for x86" }, >> > >> > /* BLOBLISTT_AREA_FIRMWARE */ >> > - { BLOBLISTT_ACPI_GNVS, "ACPI GNVS" }, >> > - { BLOBLISTT_INTEL_VBT, "Intel Video-BIOS table" }, >> > { BLOBLISTT_TPM2_TCG_LOG, "TPM v2 log space" }, >> > { BLOBLISTT_TCPA_LOG, "TPM log space" }, >> > - { BLOBLISTT_ACPI_TABLES, "ACPI tables for x86" }, >> >> There are some TPM Eventlog related entries that are missing here. >> Can we add them? >> >> > + { BLOBLISTT_ACPI_GNVS, "ACPI GNVS" }, >> > + >> > + /* BLOBLISTT_AREA_ARM */ >> > + { BLOBLISTT_OPTEE_PAGABLE_PART, "OP-TEE pagable part" }, >> > + >> > + /* BLOBLISTT_AREA_OTHER */ >> > + { BLOBLISTT_INTEL_VBT, "Intel Video-BIOS table" }, >> [...] >> >> Thanks >> /Ilias
