> Date: Thu, 30 Nov 2023 23:04:36 +0100 > From: "Janne Grunau" <j...@jannau.net> > > Hej Mark, > > On Thu, Nov 30, 2023, at 21:45, Mark Kettenis wrote: > >> From: Janne Grunau via B4 Relay <devnull+j.jannau....@kernel.org> > >> Date: Thu, 30 Nov 2023 13:42:22 +0100 > >> > >> From: Janne Grunau <j...@jannau.net> > >> > >> The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which > >> was not used by any driver at the time. The display out exposed as > >> simple-framebuffer use a power-domain controlled by a device in an > >> unmapped region. > >> Add a map covering this region as well as another MMIO region in the > >> range 0x4'0000'0000 - 0x5'0000'0000. The added regions cover all MMIO > >> annotated in Apple's device tree in this range. > >> > >> Signed-off-by: Janne Grunau <j...@jannau.net> > >> --- > >> arch/arm/mach-apple/board.c | 48 > >> +++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 48 insertions(+) > > > > Hi Janne, > > > > Is there a reason why you can't use a SZ_1G mapping for the blocks > > where you're using a SZ_512M mapping? With SZ_1G the mapping code > > will use a 1G block descriptor which avoids another level of page > > tables. > > no reason except that SZ_512M was sufficient to cover all devices in > Apple DT. Shall I resend the patch?
Yes please!
