On Tue, Nov 28, 2023 at 03:14:30PM -0600, Simon Glass wrote: > Hi Tom, > > > On Tue, Nov 28, 2023, 12:21 Tom Rini <tr...@konsulko.com> wrote: > > > On Sat, Nov 18, 2023 at 02:05:19PM -0700, Simon Glass wrote: > > > > > At present bootstd requires CONFIG_CMDLINE to operate. Add a new > > > 'programmatic' boot which can be used when no command line is available. > > > For now it does almost nothing, since most bootmeths require the > > > command line. > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > > Overall, this seems fine. The only ask I have really is, can we think > > about how to handle both this case and the case handled by > > cmd/bootmenu.c in a common fashion? To me, one is "show a menu of boot > > options, based on env variables" and one is "show a menu of boot > > options, based on C code" and the "show a menu of boot options" should > > have a lot in common. > > I had not thought about providing a menu with prog boot.
I guess I missed how there wasn't a menu with this series and conflated that with one of your other series. > Could we drop this patch from the series for now and apply the others? I > would like to finish and send the follow-on I didn't see any other feedback so yes, I'll be applying this soon'ish. -- Tom
signature.asc
Description: PGP signature