On Tue, Nov 21, 2023 at 10:54 PM Dmitry Malkin
<dmi...@bedrocksystems.com> wrote:
>
> rpi5: add initial memory map for bcm2712
Could this be the title for the patch, "initial support" is fine for
the cover letter, but doesn't really out line what this specific patch
actually does.
> includes:
> * 1GB of RAM (from 4GB or 8GB total)
> * VPU memory interface
> * SOC range (main peripherals)
Could you include details where this information came from as well please?
> Signed-off-by: Dmitry Malkin <dmi...@bedrocksystems.com>
> ---
> v2:
> new patch
> ---
> arch/arm/mach-bcm283x/init.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/mach-bcm283x/init.c b/arch/arm/mach-bcm283x/init.c
> index 7265faf6ce..362838e9b9 100644
> --- a/arch/arm/mach-bcm283x/init.c
> +++ b/arch/arm/mach-bcm283x/init.c
> @@ -68,6 +68,33 @@ static struct mm_region
> bcm2711_mem_map[MEM_MAP_MAX_ENTRIES] = {
> }
> };
>
> +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = {
> + {
> + .virt = 0x00000000UL,
> + .phys = 0x00000000UL,
> + .size = 0x3f800000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
> + PTE_BLOCK_INNER_SHARE
> + }, {
> + .virt = 0x3f800000UL,
> + .phys = 0x3f800000UL,
> + .size = 0x00800000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> + PTE_BLOCK_NON_SHARE |
> + PTE_BLOCK_PXN | PTE_BLOCK_UXN
> + }, {
> + .virt = 0x107c000000UL,
> + .phys = 0x107c000000UL,
> + .size = 0x0004000000UL,
> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
> + PTE_BLOCK_NON_SHARE |
> + PTE_BLOCK_PXN | PTE_BLOCK_UXN
> + }, {
> + /* List terminator */
> + 0,
> + }
> +};
> +
> struct mm_region *mem_map = bcm283x_mem_map;
>
> /*
> @@ -78,6 +105,7 @@ static const struct udevice_id board_ids[] = {
> { .compatible = "brcm,bcm2837", .data = (ulong)&bcm283x_mem_map},
> { .compatible = "brcm,bcm2838", .data = (ulong)&bcm2711_mem_map},
> { .compatible = "brcm,bcm2711", .data = (ulong)&bcm2711_mem_map},
> + { .compatible = "brcm,bcm2712", .data = (ulong)&bcm2712_mem_map},
> { },
> };
>
> --
> 2.40.1
