On Fri, Nov 17, 2023 at 09:17:27AM +0100, Stefano Babic wrote: > Hi Tom, Marcel, > > On 16.11.23 19:42, Tom Rini wrote: > > On Thu, Nov 16, 2023 at 10:57:27AM +0000, Marcel Ziswiler wrote: > > > Hi Tom > > > > > > On Thu, 2023-11-02 at 08:09 +0100, Marcel Ziswiler wrote: > > > > Hi Stefano > > > > > > > > On Thu, 2023-10-26 at 10:36 +0200, Stefano Babic wrote: > > > > > On 26.10.23 10:29, Rasmus Villemoes wrote: > > > > > > On 26/10/2023 09.32, Marcel Ziswiler wrote: > > > > > > > From: Marcel Ziswiler <marcel.ziswi...@toradex.com> > > > > > > > > > > > > > > This fixes a regression in the eMMC fast boot mode case where the > > > > > > > buffer > > > > > > > was missing 464 bytes. > > > > > > > > > > > > > > The code figures out how many bytes must at least be fetched to > > > > > > > honor > > > > > > > the current read, rounds that up to the ss->pagesize [which is a > > > > > > > no-op > > > > > > > in the USB download case because that has ->pagesize==1], fetches > > > > > > > that > > > > > > > many bytes, but then recorded the original upper bound as the new > > > > > > > end of > > > > > > > the valid data. However, this did not take into account the > > > > > > > rounding up > > > > > > > to the ss->pagesize. Fix this by recording the actual bytes > > > > > > > downloaded. > > > > > > > > > > > > > > Fixes: 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of > > > > > > > spl_load_simple_fit() to get full FIT > > > > > > > size") > > > > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswi...@toradex.com> > > > > > > > > > > > > > > > > > > > Thanks for reporting and fixing this, and sorry for the trouble. > > > > > > > > > > > > Acked-by: Rasmus Villemoes <rasmus.villem...@prevas.dk> > > > > > > > > > > > > > > > > And thanks for all your work - I will apply this fix soon. > > > > > > > > Any news on applying this fix? Note that master still stays broken as > > > > of today. > > > > > > And two weeks later still broken! > > > > I've put this in my not to forget queue for the next -rc. > > > > > Anyway, I feel i.MX maintainership seems rather stalled at times most of > > > the time. I don't want to criticise > > > anybody knowing how busy our trade can get. However, if it helps the > > > cause Toradex would be ready to step up. > > > Let me know what you think. Thanks! > > > > I would be happy to see an additional custodian for the imx tree, if > > that's agreeable with Stefano. > > I have rather less time for U-Boot and it won't be better in the near > future. Fabio is co-maintainer and he has accepted to take over the > repository and go on maintaining u-boot-imx. Just let him some time to be > confident with patchwork and CI.
OK. Fabio, please send me your patchwork username off-list and I'll get you added and you can start managing patches there. I've started using some of the b4 + patchwork integration just recently and it's very nice. -- Tom
signature.asc
Description: PGP signature