On Tue, Oct 31, 2023 at 06:29:20PM +0530, Love Kumar wrote:

> Abort the dhcp request in the middle by pressing ctrl + c on u-boot
> prompt and validate the abort status.
> 
> Signed-off-by: Love Kumar <love.ku...@amd.com>
> ---
> Changes in v2:
> - Mark CMD_MII command dependency

This doesn't work for me on a raspberry pi 3 in 32bit mode (and I
suspect fails on the rest of the Pi families and builds as well):
test/py/tests/test_net.py ..F

========================================== FAILURES 
===========================================
_____________________________________ test_net_dhcp_abort 
_____________________________________
test/py/tests/test_net.py:139: in test_net_dhcp_abort
    eth_num = re.search(r"Current device: '(.+?)'", output).groups()[0]
E   AttributeError: 'NoneType' object has no attribute 'groups'
------------------------------------ Captured stdout call 
-------------------------------------
U-Boot> setenv autoload no
U-Boot> U-Boot> mii device
MII devices:
U-Boot>
=================================== short test summary info 
===================================
FAILED test/py/tests/test_net.py::test_net_dhcp_abort - AttributeError: 
'NoneType' object ha...
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures 
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
========================= 1 failed, 101 passed, 86 skipped in 39.89s 
==========================

Perhaps the method you use to interrupt the dhcp attempt needs
re-thinking? I don't know if we can reliably inject control-c instead
quick enough to the console.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to