Hi Nishanth On Fri, 2023-10-27 at 15:46 -0500, Nishanth Menon wrote: > On 16:46-20231027, Roger Quadros wrote: > > Hi, > > > > Since commit [1], Ethernet is broken on TI AM62 and AM64 platforms. > > > > The commit [1] is not the culprit. It just unearths the problem by fixing > > the error check in k3-udma.c. This issue was silently being ignored earlier > > due to wrong error check. [NULL instead of FDT_ADDR_T_NONE]. > > > > Fix the issue by adding the necessary register spaces for the u-boot K3-UDMA > > driver for AM62 and AM64 platforms. > > > > [1] - 5fecea171de3dd ("treewide: use dev_read_addr_*_ptr() where > > appropriate") > > > > cheers, > > -roger > > > > Roger Quadros (1): > > arm: dts: k3-am625-verdin-wifi-dev-u-boot.dtsi: Fix DMA/Ethernet > > > > Siddharth Vadapalli (2): > > arm: dts: k3-am625-sk-u-boot.dtsi: Update main_bcdma and main_pktdma > > nodes > > arm: dts: k3-am642: Update main_bcdma and main_pktdma nodes > > > > arch/arm/dts/k3-am625-sk-u-boot.dtsi | 27 +++++++++++++++++++ > > .../dts/k3-am625-verdin-wifi-dev-u-boot.dtsi | 27 +++++++++++++++++++ > > arch/arm/dts/k3-am642-evm-u-boot.dtsi | 27 +++++++++++++++++++ > > arch/arm/dts/k3-am642-sk-u-boot.dtsi | 23 ++++++++++++++++ > > 4 files changed, 104 insertions(+) > > > > > > base-commit: 351da15f71e3d70dbc63e90781b403415452d864 > > -- > > 2.34.1 > > > > > Thanks for this. > > Reviewed-by: Nishanth Menon <n...@ti.com> > > NOTE: These extra properties are already in discussion in Linux > community. > > https://lore.kernel.org/linux-arm-kernel/20230810174356.3322583-1-vigne...@ti.com/ > > Marcel, could the Toradex team confirm as well?
Yes, I just successfully tested it. With what you say above I also assume eventually those properties will move to the SoC dtsi rather than having to be separately defined U-Boot-specific in each and every board. Thanks guys. Cheers Marcel