On 10/19/23 00:42, Bryan Brattlof wrote: > Hi Thomas! > > On October 16, 2023 thus sayeth Thomas Richard: >> Add the exit retention support. >> The enter retention is done by DM-Firmware. >> A part of the exit retention sequence is specific to the board. >> It is done in board_k3_ddrss_lpddr4_release_retention. >> >> Based on the work of Gregory CLEMENT <gregory.clem...@bootlin.com> >> >> Signed-off-by: Thomas Richard <thomas.rich...@bootlin.com> >> Signed-off-by: Gregory CLEMENT <gregory.clem...@bootlin.com> >> --- >> >> drivers/ram/k3-ddrss/k3-ddrss.c | 302 ++++++++++++++++++++++++++++++++ >> 1 file changed, 302 insertions(+) >> > > Do you mind putting this behind some type of Kconfig option? For the > am62* class of devices the amount of SRAM we have is really stretched > thin. I'm worried this may put us over the top.
Hi Bryan, Maybe I could put this behind the Kconfig option K3_J721E_DDRSS. K3_J721E_DDRSS is set if SOC_K3_J721E or SOC_K3_J721S2, and later SOC_K3_J784S4 (https://elixir.bootlin.com/u-boot/latest/source/drivers/ram/Kconfig#L65). For now it was only tested on J7200, but we can assume that most of the code will be valid for J721S2 (and later J784S4). And the code will not be compiled for am6*. Regards, Thomas > > ~Bryan