On Fri, Oct 13, 2023 at 08:15:00AM -0700, Simon Glass wrote: > On Thu, 12 Oct 2023 at 16:04, Tom Rini <tr...@konsulko.com> wrote: > > > > At this point in time we should not add common.h to any new files, so > > make checkpatch.pl complain. > > > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > --- > > Cc: Simon Glass <s...@chromium.org> > > > > This causes a bunch of patman tests, for checkpatch, to now fail and I > > don't really understand why, at all. And that was before I added a test > > for the new error, which I had hoped would clear up the problem. > > --- > > scripts/checkpatch.pl | 8 +++++++- > > tools/patman/test_checkpatch.py | 7 ++++++- > > 2 files changed, 13 insertions(+), 2 deletions(-) > > Reviewed-by: Simon Glass <s...@chromium.org>
It can't be reviewed, as I can't actually apply it, as it causes CI to fail as patman tests now fail, and I don't know why. -- Tom
signature.asc
Description: PGP signature
