On 12:31-20231005, Tom Rini wrote: [...] > > > /* Now for the remaining common defines */ > > > #include <configs/ti_armv7_common.h> > > > > It looks like this file still includes distro_bootcmd and defines all > > the BOOT_TARGET things. Can they be dropped? Perhaps for now they > > could be put behind an #ifdef if other boards need them? > > > > I suspect that with your patch as is, the environment is still full of > > scripts? > > There's a lot of TI platforms, so I'm not sure what "#if" you're > thinking of might make it cleaner? We could / should move some of the > still relevant content and comments from that file to > include/env/ti/ti_armv7_common.env as I do think some of the K3 > platforms could just drop <configs/ti_armv7_common.h> at this point.
Is'nt the header distro_bootcmd.h and related stuff under #ifdef CONFIG_DISTRO_DEFAULTS already? So, all we are picking up in effect is really CFG_SYS_SDRAM_BASE - which is consistent across platforms. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
