On 03/10/2023 14:27, Marek Vasut wrote: > On 9/20/23 14:42, Paul Barker wrote: >> We don't want to rely on source files including <asm/types.h> before >> <asm/arch/rmobile.h>. > > What kind of error does this solve ?
Without this, <asm/types.h> must be included before
<asm/arch/rmobile.h>, for example in include/configs/rzg2l-smarc.h added
in patch 16, to avoid the following error:
CC arch/arm/lib/asm-offsets.s
In file included from include/configs/rzg2l-smarc.h:9,
from include/config.h:3,
from include/common.h:16,
from lib/asm-offsets.c:14:
./arch/arm/include/asm/arch/rmobile.h:49:7: error: unknown type name ‘u8’
49 | const u8 *rzg_get_cpu_name(void);
| ^~
In file included from include/configs/rzg2l-smarc.h:9,
from include/config.h:3,
from include/common.h:16,
from arch/arm/lib/asm-offsets.c:19:
./arch/arm/include/asm/arch/rmobile.h:49:7: error: unknown type name ‘u8’
49 | const u8 *rzg_get_cpu_name(void);
| ^~
./arch/arm/include/asm/arch/rmobile.h:50:1: error: unknown type name ‘u32’
50 | u32 rmobile_get_cpu_type(void);
| ^~~
./arch/arm/include/asm/arch/rmobile.h:50:1: error: unknown type name ‘u32’
50 | u32 rmobile_get_cpu_type(void);
| ^~~
./arch/arm/include/asm/arch/rmobile.h:51:1: error: unknown type name ‘u32’
51 | u32 rmobile_get_cpu_rev_integer(void);
| ^~~
./arch/arm/include/asm/arch/rmobile.h:52:1: error: unknown type name ‘u32’
52 | u32 rmobile_get_cpu_rev_fraction(void);
| ^~~
./arch/arm/include/asm/arch/rmobile.h:51:1: error: unknown type name ‘u32’
51 | u32 rmobile_get_cpu_rev_integer(void);
| ^~~
./arch/arm/include/asm/arch/rmobile.h:52:1: error: unknown type name ‘u32’
52 | u32 rmobile_get_cpu_rev_fraction(void);
| ^~~
make[1]: *** [scripts/Makefile.build:146: arch/arm/lib/asm-offsets.s]
Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:146: lib/asm-offsets.s] Error 1
make: *** [Makefile:1916: prepare0] Error 2
Thanks,
Paul
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
