Hi Simon, On 19:17-20231001, Simon Glass wrote: > Hi Manorit, > > On Tue, 26 Sept 2023 at 01:58, Manorit Chawdhry <m-chawd...@ti.com> wrote: > > > > We can now firewall entities while loading them through our secure > > entity TIFS, the required information should be present in the > > certificate that is being parsed by TIFS. > > > > The following commit adds the support to enable the certificates to be > > generated if the firewall configurations are present in the binman dtsi > > nodes. > > > > Signed-off-by: Manorit Chawdhry <m-chawd...@ti.com> > > --- > > tools/binman/btool/openssl.py | 16 +++++++- > > tools/binman/etype/ti_secure.py | 85 > > +++++++++++++++++++++++++++++++++++++++++ > > tools/binman/etype/x509_cert.py | 3 +- > > 3 files changed, 101 insertions(+), 3 deletions(-) > > > > Please do check that you have 100% test coverage here (binman test -T) >
Name Stmts Miss Cover --------------------------------------------------------------------------- [snip] tools/binman/btool/openssl.py 42 0 100% tools/binman/etype/ti_secure.py 57 0 100% tools/binman/etype/x509_cert.py 70 0 100% [snip] --------------------------------------------------------------------------- TOTAL 5588 134 98% I did check that, did you notice something else that I might've missed? I just checked for the files that I have changed, I am not sure if there are any dependencies that I also have to keep in mind. Do let me know if I missed something. Regards, Manorit > Regards, > Simon
