On Wed, Sep 27, 2023 at 11:14 AM Troy Kisky <troykiskybound...@gmail.com> wrote:
> > > On Mon, Jun 19, 2023 at 4:07 PM Troy Kisky <troykiskybound...@gmail.com> > wrote: > >> Add script usage_of_is_enabled_check to print any configs that >> use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa. >> >> Add usage_of_is_enabled_commit.sh to generate commits to fix the above >> issues. >> >> You can remove entries from test/usage_of_is_enabled_todo.txt >> or the entire file and then run >> test/usage_of_is_enabled_commit.sh >> to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED >> >> or run test/usage_of_is_enabled_check.sh to >> see which configs are still todo. >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> Signed-off-by: Troy Kisky <troykiskybound...@gmail.com> >> --- >> >> (no changes since v1) >> >> .azure-pipelines.yml | 11 ++ >> .gitlab-ci.yml | 5 + >> test/usage_of_is_enabled_check.sh | 19 +++ >> test/usage_of_is_enabled_commit.sh | 12 ++ >> test/usage_of_is_enabled_correct.sh | 50 +++++++ >> test/usage_of_is_enabled_exempt.txt | 9 ++ >> test/usage_of_is_enabled_list.sh | 86 +++++++++++ >> test/usage_of_is_enabled_splcfg.txt | 21 +++ >> test/usage_of_is_enabled_todo.txt | 213 ++++++++++++++++++++++++++++ >> 9 files changed, 426 insertions(+) >> create mode 100755 test/usage_of_is_enabled_check.sh >> create mode 100755 test/usage_of_is_enabled_commit.sh >> create mode 100755 test/usage_of_is_enabled_correct.sh >> create mode 100644 test/usage_of_is_enabled_exempt.txt >> create mode 100755 test/usage_of_is_enabled_list.sh >> create mode 100644 test/usage_of_is_enabled_splcfg.txt >> create mode 100644 test/usage_of_is_enabled_todo.txt >> >> > If this patch is still desirable, it can be updated by > > rm test/usage_of_is_enabled_todo.txt > test/usage_of_is_enabled_check.sh >test/usage_of_is_enabled_todo.txt > > And delete the last 2 lines sed -i '$d' test/usage_of_is_enabled_todo.txt sed -i '$d' test/usage_of_is_enabled_todo.txt > BR > Troy > >