Dear Kyle Moffett,
In message <1298311199-18775-3-git-send-email-kyle.d.moff...@boeing.com> you
wrote:
> Use #define constants to enhance readability of DDR2/3 SPD parsing code.
> Also add the DDR2 type for an SO-RDIMM module to the switch statement.
>
> Signed-off-by: Kyle Moffett <kyle.d.moff...@boeing.com>
> ---
> arch/powerpc/cpu/mpc8xxx/ddr/ddr2_dimm_params.c | 34 +++++++++++++++------
> arch/powerpc/cpu/mpc8xxx/ddr/ddr3_dimm_params.c | 37
> ++++++++++-------------
> common/ddr_spd.c | 2 +-
> include/ddr_spd.h | 28 ++++++++++++-----
> 4 files changed, 60 insertions(+), 41 deletions(-)
...
> + case DDR3_SPD_MODULETYPE_UDIMM:
> + case DDR3_SPD_MODULETYPE_SO_DIMM:
> + case DDR3_SPD_MODULETYPE_MICRO_DIMM:
> + case DDR3_SPD_MODULETYPE_MINI_UDIMM:
> + /* Unbuffered DIMMs */
> + pdimm->registered_dimm = 0;
> + pdimm->mirrored_dimm = spd->mod_section.unbuffered.addr_mapping
> & 0x1;
> break;
Line too long. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The thing is, as you progress in the Craft, you'll learn there is
another rule... When you break rules, break 'em good and hard.
- Terry Pratchett, _Wyrd Sisters_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
