On Tue, Jun 20, 2023 at 12:45:54AM +0200, Marek Vasut wrote: > Pull the PHY GPIO reset code into separate function, since > this is and will be reused multiple times. Set up default > reset assert and deassert timing to generous 20ms and 1ms > for maximum compatibility in case those DT properties are > missing. > > Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org> > Reviewed-by: Ramon Fried <rfried....@gmail.com> > --- > Cc: Joe Hershberger <joe.hershber...@ni.com> > Cc: Marek Vasut <marek.vasut+rene...@mailbox.org> > Cc: Michal Simek <michal.si...@amd.com> > Cc: Nishanth Menon <n...@ti.com> > Cc: Ramon Fried <rfried....@gmail.com> > --- > drivers/net/phy/ethernet_id.c | 37 ++++----------------------- > drivers/net/phy/phy.c | 47 +++++++++++++++++++++++++++++++++++ > include/phy.h | 9 +++++++ > 3 files changed, 61 insertions(+), 32 deletions(-)
This introduces a fail to build on am335x_evm (and others) as before thee code was guarded by CONFIG_DM_ETH_PHY (which I haven't seen how then leads to DM_GPIO/SPL_DM_GPIO/etc being set) and now does not. -- Tom
signature.asc
Description: PGP signature
