Dear Richard Retanubun,
In message <1297888074-8344-3-git-send-email-richardretanu...@ruggedcom.com>
you wrote:
> This patch adds [+]len handler for the erase command that will
> automatically round up the requested erase length to the flash's
> sector_size.
> ---
> common/cmd_sf.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++----
> 1 files changed, 49 insertions(+), 4 deletions(-)
Please run your patches through checkpatch - this helps avoiding the
frustration of seeing rejects due to simple issues like these:
ERROR: Missing Signed-off-by: line(s)
> + if (*arg == '+'){
ERROR: space required before the open brace '{'
> + if (ret != 1) {
> goto usage;
> + }
WARNING: braces {} are not necessary for single statement blocks
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
All these theories, diverse as they are, have two things in common:
they explain the observed facts, and they are completeley and utterly
wrong. - Terry Pratchett, _The Light Fantastic_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
