On 19:20-20230714, Neha Malcom Francis wrote: Since you are going to respin anyways, I will complain about this:
> +#ifdef CONFIG_TARGET_J721E_A72_EVM > + > +#define SPL_NODTB "spl/u-boot-spl-nodtb.bin" > +#define SPL_J721E_EVM_DTB "spl/dts/k3-j721e-common-proc-board.dtb" > +#define SPL_J721E_SK_DTB "spl/dts/k3-j721e-sk.dtb" > + > +#define UBOOT_NODTB "u-boot-nodtb.bin" > +#define J721E_EVM_DTB "arch/arm/dts/k3-j721e-common-proc-board.dtb" > +#define J721E_SK_DTB "arch/arm/dts/k3-j721e-sk.dtb" > + I was trying to add beaglebone-ai64 support and discovered that this messes the reuse of j721e-binman.dtsi for ai64. I am forced to introduce j721e-sk.dtb - so why not just use SPL_NODTB SPL_J721E_BOARD_DTB, UBOOT_NODTB J721E_EVM_BOARD_DTB (generic names) and drop the specific sk stuff? And define the macros in the board.dtsi prior to including the files? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
