Hi, On 02/08/2011 09:29 PM, Scott Wood wrote: > On Wed, Feb 02, 2011 at 04:11:29PM +0100, Michael Trimarchi wrote: >> Hi, >> >> this patch fix the support for CE don't care nand >> >> Michael Trimarchi > > Please read http://www.denx.de/wiki/U-Boot/Patches and follow the > format therein -- don't use attachments. > The thunderbird config was wrong. I will use mutt next time >> commit 0cb23ef858407a7a9de6e353e08394637c518c89 >> Author: Michael Trimarchi <mich...@evidence.eu.com> >> Date: Wed Feb 2 14:24:21 2011 +0100 >> >> Fix the CE for the NAND don't care >> >> Signed-off-by: Michael Trimarchi <mich...@evidence.eu.com> > > The changelog needs to be more descriptive. What is "NAND don't care"? > What is broken? > >From atmel documentation:
"CE connection depends on the NAND Flash. For standard NAND Flash devices, it must be connected to any free PIO line. For “CE don’t care” NAND Flash devices, it can be connected to either NCS3/NANDCS or to any free PIO line." Hope that is more clear now. Linux use an hook to do it and u-boot a #define >> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c >> index ab8bbb3..bda117a 100644 >> --- a/drivers/mtd/nand/atmel_nand.c >> +++ b/drivers/mtd/nand/atmel_nand.c >> @@ -249,8 +249,13 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd, >> if (ctrl & NAND_ALE) >> IO_ADDR_W |= CONFIG_SYS_NAND_MASK_ALE; >> >> + /* >> + * Nand CS don't care doesn't need the enable pin >> + */ >> +#ifdef CONFIG_SYS_NAND_ENABLE_PIN >> at91_set_gpio_value(CONFIG_SYS_NAND_ENABLE_PIN, >> !(ctrl & NAND_NCE)); >> +#endif > New CONFIG symbols need to be documented, and this particular one should > probably be less generic. There is not a new CONFIG symbol, I just skip that code that is not necessary for this type of NAND > -Scott > I will resend it Michael _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
