Hi Pali, On Mon, 12 Jun 2023 at 21:22, Pali Rohár <p...@kernel.org> wrote: > > On Monday 12 June 2023 21:14:32 Simon Glass wrote: > > The intent here was to allow ANSI codes to be disabled, since it was > > proving impoosible to test operation of the menu code when it kept moving > > the cursor. Unfortunately this ended up in the patch. > > > > Correct this by enabling ANSI again. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > Reported-by: Pali Rohár <p...@kernel.org> > > Reported-by: Mark Kettenis <mark.kette...@xs4all.nl> > > Reported-by: Frank Wunderlich <fran...@public-files.de> > > Fixes: 32bab0eae51b ("menu: Make use of CLI character processing") > > --- > > > > common/menu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/common/menu.c b/common/menu.c > > index 94514177e4e9..b55cf7b99967 100644 > > --- a/common/menu.c > > +++ b/common/menu.c > > @@ -15,7 +15,7 @@ > > > > #include "menu.h" > > > > -#define ansi 0 > > +#define ansi 1 > > > > /* > > * Internally, each item in a menu is represented by a struct menu_item. > > -- > > 2.41.0.162.gfafddb0af9-goog > > > > Hello, I have tested this change but bootmenu still does not work. There > is still same issue which I reported month ago. When I press DOWN key > then bootmenu immediately quit instead of moving into the next entry.
Thanks for testing this. Is there a way for me to test this with sandbox? Or does your Nokia test check it? I'm sure you have this commit:? 17b45e684af9 ("cli: Correct several bugs in cli_getch()") Regards, Simon