Hi Jonas, On Wed, 3 May 2023 at 08:17, Jonas Karlman <jo...@kwiboo.se> wrote: > > Hi Simon, > > On 2023-05-03 14:41, Simon Glass wrote: > > This makes MMC extremely slow on bob. Even reading the environment takes > > ages. > > > > If there is a bug on a particular controller, it should be worked around > > using the compatible string, e.g. with ->flags in struct sdhci_data - > > althought I don't see any docs for the flags. > > This revert will break booting from emmc on rock5b-rk3588. > > An alternative to this revert could be to enable CONFIG_MMC_SDHCI_SDMA > for more rk3399 defconfigs. Using DMA should improve/restore performance. > > I have a followup patch in the works that changes this slightly, can > include a change to only apply this workaround for rk35xx.
OK, but please use the compatible string for any workarounds. Regards, Simon