On Sun, Apr 30, 2023 at 11:20:35PM +0200, Marek Vasut wrote: > In case NET networking is not enabled, it is not possible to compile > the USB ethernet gadget. Protect the symbols in Makefile to avoid build > failure. Such build failure may occur e.g. in case NET and USB ethernet > gadget is enabled in U-Boot proper, but not in SPL. > > Signed-off-by: Marek Vasut <ma...@denx.de> > --- > Cc: Lukasz Majewski <lu...@denx.de> > --- > drivers/usb/gadget/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile > index 6cfe0f3a041..36f65e7eb95 100644 > --- a/drivers/usb/gadget/Makefile > +++ b/drivers/usb/gadget/Makefile > @@ -34,8 +34,10 @@ endif > > obj-$(CONFIG_CI_UDC) += ci_udc.o > > +ifeq ($(CONFIG_$(SPL_TPL_)NET),y) > obj-$(CONFIG_USB_ETHER) += ether.o > obj-$(CONFIG_USB_ETH_RNDIS) += rndis.o > +endif > > # Devices not related to the new gadget layer depend on CONFIG_USB_DEVICE > # This is really only N900 and USBTTY now.
Why can't we just enforce this via Kconfig? -- Tom
signature.asc
Description: PGP signature