On 13:07-20230413, Nishanth Menon wrote:
> Originally reported by Tom[1], turned out to be that recent commit
> 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux")
> reordered the enum definitions which in turn broke the range checks.
>
> we are left with two options:
> a) check against explicit values to help reuse as much as possible and
> let compiler optimize where applicable
> or
> b) be very explicit in phy drivers and drop these helpers.
>
> I have chosen to go with (a) approach.
>
> Tested on am64x, though the dp83867 is used elsewhere as well.
>
> Nishanth Menon (2):
> net: phy: Make phy_interface_is_sgmii a switch statement
> net: phy: Make phy_interface_is_rgmii a switch statement
>
> include/phy.h | 24 ++++++++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> --
> 2.40.0
>
Oops.. forgot to provide the link of the report:
[1] https://libera.irclog.whitequark.org/u-boot/2023-04-07#34130437;
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
