On Wed, Mar 1, 2023 at 7:33 AM Tom Rini <tr...@konsulko.com> wrote:
> On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote: > > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for > > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation. > > > > Signed-off-by: Troy Kisky <troykiskybound...@gmail.com> > > Reviewed-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v1) > > > > tools/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/Makefile b/tools/Makefile > > index 5d6284e6451..86f1b6b5049 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -162,8 +162,10 @@ ifdef CONFIG_TOOLS_LIBCRYPTO > > # This affects include/image.h, but including the board config file > > # is tricky, so manually define this options here. > > HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE > > +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_SIGNATURE=1 > > HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff > > HOST_EXTRACFLAGS += -DCONFIG_FIT_CIPHER > > +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_CIPHER=1 > > endif > > Is the "=1" required here, as in we check the value of the define, not > just that it is defined? > > -- > Tom > When it is converted to CONFIG_IS_ENABLED it will require the =1 The CONFIG_IS_ENABLED logic counts the number of parameters and "empty string" doesn't count. I think it also compares to 1 somewhere in there. BR Troy