On Wed, Mar 01, 2023 at 08:39:23PM -0700, Simon Glass wrote: > These board have moved to standard boot but the old 'distro_bootcmd' > command is still active. Disable DISTRO_DEFAULTS to fix this. > > Signed-off-by: Simon Glass <s...@chromium.org> > Tested-by: Vagrant Cascadian <vagr...@debian.org> > --- > > (no changes since v1) > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index bd7fffcce0b..4e7ebeaee87 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1955,7 +1955,7 @@ config ARCH_ROCKCHIP > imply ADC > imply CMD_DM > imply DEBUG_UART_BOARD_INIT > - imply DISTRO_DEFAULTS > + imply DISTRO_DEFAULTS if !ROCKCHIP_RK3399 > imply FAT_WRITE > imply SARADC_ROCKCHIP > imply SPL_SYSRESET
This is just opening the door to the next conversion failing for the same reason I think. We need a new Kconfig symbol, DISTRO_BOOTCMD which is askable and default y depends on DISTRO_DEFAULTS. Then you can do imply/select logic for the conversion based on if they have DISTRO_BOOTCMD or BOOTSTD_BOOTCOMMAND. Because part of the problem here is that we don't have an option for distro_bootcmd itself, so we need one. That's in essence the second half of the patch you did which moves "this is functionality really everyone should enable, for a good general user experience" out of DISTRO_DEFAULTS&&BOOTSTD_DEFAULTS and in to its own symbol. -- Tom
signature.asc
Description: PGP signature
