Dear Lei Wen,
In message <1294632087-8025-3-git-send-email-lei...@marvell.com> you wrote:
> Pantheon Family processors are highly integrated SoCs
> based on Sheeva_88SV331x-v5 PJ1 cpu core.
> Ref:
> http://www.marvell.com/products/processors/communications/marvell_pantheon_910_920_pb.pdf
>
> SoC versions Supported:
> 1) PANTHEON920 (TD)
> 2) PANTHEON910 (TTC)
>
> Signed-off-by: Lei Wen <lei...@marvell.com>
...
> +int dram_init(void)
> +{
...
> + for (; i < CONFIG_NR_DRAM_BANKS; i++) {
> + /* If above loop terminated prematurely, we need to set
> + * remaining banks' start address & size as 0. Otherwise other
> + * u-boot functions and Linux kernel gets wrong values which
> + * could result in crash */
Incorrect multiline comment style.
> +/* For preventing risk of instability in reading counter value,
> + * first set read request to register cvwr and then read same
> + * register after it captures counter value.
> + */
Ditto. Please fix globally.
> + writel(COUNT_RD_REQ, &panthtimers->cvwr);
> + while (loop--);
Please write:
while (loop--)
;
But then - are you sure the compiler does not optimize this out? You
probably want to use __udelay() instead.
...
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-pantheon/config.h
> @@ -0,0 +1,44 @@
...
> +/*
> + * There is no internal RAM in ARMADA100, using DRAM
> + * TBD: dcache to be used for this
> + */
> +#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_TEXT_BASE -
> 0x00200000)
> +#define CONFIG_NR_DRAM_BANKS_MAX 2
This looks like board specific code that should not be here.
...
> +struct panthmpmu_registers {
> + u8 pad0[0x0024];
> + u32 ccgr; /*0x0024*/
> + u8 pad1[0x0200 - 0x024 - 4];
> + u32 wdtpcr; /*0x0200*/
> + u8 pad2[0x1020 - 0x200 - 4];
> + u32 aprr; /*0x1020*/
> + u32 acgr; /*0x1024*/
> +};
Please use TAB for vertical alignment of variable names. Please fix
globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You see but you do not observe.
Sir Arthur Conan Doyle, in "The Memoirs of Sherlock Holmes"
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
