On 2/21/23 21:35, Simon Glass wrote:
On Sat, 18 Feb 2023 at 01:34, Heinrich Schuchardt
<heinrich.schucha...@canonical.com> wrote:

Building sandbox_spl with CONFIG_DEBUG leads to errors due to missing
symbols:

     /usr/bin/ld: common/spl/spl_fit.o: in function `spl_fit_upload_fpga':
     common/spl/spl_fit.c:595: undefined reference to `fpga_load'
     /usr/bin/ld: test/test-main.o: in function `dm_test_post_run':
     test/test-main.c:124: undefined reference to `crc8'
     /usr/bin/ld: test/test-main.o: in function `dm_test_pre_run':
     test/test-main.c:95: undefined reference to `crc8'
     collect2: error: ld returned 1 exit status

This is due to -Og not eliminating unused functions.

Add FPGA and CRC8 support to the defconfig. Sandbox tests for
SPL_FPGA and CRC8 should be created. So enabling these setting
is advised anyway.

Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
---
  configs/sandbox_spl_defconfig | 4 ++++
  1 file changed, 4 insertions(+)


Reviewed-by: Simon Glass <s...@chromium.org>

Hello Heinrich, Simon,

I am facing similar issues on different defconfig when enabling OPTIMIZE_DEBUG.
I don't think enabling SPL_FPGA and DM_FPGA is the solution there.
Do you know why is the drivers/fpga/fpga.c built all the time, with no Kconfig selected ? I think that maybe spl_fit_upload_fpga and fpga_load should be built conditionally , I would like to have SPL load a FIT, but not anything related to FPGA in my config.

Thanks,
Eugen

Reply via email to