On Tue, Jan 31, 2023 at 02:44:52AM +0530, Jagan Teki wrote: > On Mon, 30 Jan 2023 at 20:45, Tom Rini <tr...@konsulko.com> wrote: > > > > On Mon, Jan 30, 2023 at 08:29:35PM +0530, Jagan Teki wrote: > > > On Fri, 27 Jan 2023 at 12:51, Jagan Teki <ja...@edgeble.ai> wrote: > > > > > > > > This reverts commit f5315dd6290a588434e4f79bfd2886bb7df9210d. > > > > > > > > [why] > > > > TPL is not mandatory for not all Rockchip SoCs, some SoCs like > > > > RK356x, and RK3588 still use mainline u-boot without TPL as > > > > their ddr init programs are accessed via binaries provided by > > > > Rockchip instead of ddr source code. > > > > > > > > Marking TPL build makes it not able to build u-boot.itb on > > > > RK356x targets so revert this so that it can build an SPL build > > > > that would support all across Rockchip platforms. > > > > > > > > Suggested-by: Quentin Schulz <quentin.sch...@theobroma-systems.com> > > > > Signed-off-by: Jagan Teki <ja...@edgeble.ai> > > > > --- > > > > > > Can someone apply this before -rc is released? > > > > Yes, but where's the follow-up series to make both cases work again, I > > think I missed it? > > No follow-up series from my side, I think this revert will compatible > with all rockchip platforms.
Well, I assumed there was some subset that needed this change or Kever wouldn't have posted and merged his change so close to the release. And I do think we need something with CONFIG_BUILD_TARGET so that this problem would have been caught in CI, in the future. -- Tom
signature.asc
Description: PGP signature
