On 25/01/2023 15.28, Rasmus Villemoes wrote:
> On 20/01/2023 16.23, Tom Rini wrote:
>> On Fri, Jan 20, 2023 at 08:30:27AM +0000, Peter Robinson wrote:
>>> On Thu, Jan 19, 2023 at 2:02 PM Tom Rini <tr...@konsulko.com> wrote:
>>>>
>>>> On Thu, Jan 19, 2023 at 11:52:11AM +0000, Peter Robinson wrote:
>>>>> On Thu, Jan 19, 2023 at 11:33 AM Fabio Estevam <feste...@gmail.com> wrote:
>>>>>>
>>>>>> On Thu, Jan 19, 2023 at 8:18 AM Peter Robinson <pbrobin...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Did you read the original thread?
>>>>>>
>>>>>> I only read your commit log and it is not clear if it is a regression
>>>>>> and which commit caused the problem.
>>>>>
>>>>> I don't remember, this was back in November.
>>>>>
>>>>>> It lacks a Fixes tag too.
>>>>>
>>>>> Which are mostly pointless in U-Boot as it's not like the kernel where
>>>>> there's stable release cycles.
>>>>
>>>> They're quite helpful, in order to track when changes are fixing a
>>>> problem that was introduced by some other commit.
So I also got curious about that part, because when I build
tools-only_defconfig with older U-Boot releases I don't get a bmp_logo
tool built.
I think I figured that out (but only after it's been revealed that this
was about Fedora's packaging of u-boot-tools). Fedora seems to do
%make_build HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE=""
tools-only_defconfig O=builds/
%make_build HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" tools-all O=builds/
so unlike the Yocto case, the build target is tools-all and not
cross_tools. Hence the top Makefile sets HOST_TOOLS_ALL=y, which in
tools/Makefile then hits
ifneq ($(HOST_TOOLS_ALL),)
CONFIG_ARCH_KIRKWOOD = y
...
endif
and that block used to, until 1dc6517649f2, contain
CONFIG_LCD_LOGO = y
with the corresponding
hostprogs-$(CONFIG_LCD_LOGO) += bmp_logo
further down.
IOW, it wasn't really tools-only_defconfig per se that used to cause
bmp_logo to get built, it was the tools-all target.
Rasmus
