Dear Wolfgang Denk,
Thank you very much for your review.
2011/01/18 18:28, Wolfgang Denk wrote:
>> @@ -37,6 +37,7 @@ COBJS-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
>> COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
>> COBJS-$(CONFIG_OMAP3_SPI) += omap3_spi.o
>> COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
>> +COBJS-$(CONFIG_SH_SPI) += sh_spi.o
>
> Please keep list sorted.
I will fix it.
>> +#define SPI_TBR 0x00
>> +#define SPI_RBR 0x00
>> +#define SPI_CR1 0x08
>> +#define SPI_CR2 0x10
>> +#define SPI_CR3 0x18
>> +#define SPI_CR4 0x20
>
> Please declare a poper C struct instead.
I will modify it.
>> +/* CR4 */
>> +#define SPI_TBEI 0x80
>> +#define SPI_TBFI 0x40
>> +#define SPI_RBEI 0x20
>> +#define SPI_RBFI 0x10
>> +#define SPI_WPABRT 0x04
>> +#define SPI_SSS 0x01
>> +
>> +#define SPI_FIFO_SIZE 32
>
> All this stuff should better go into a separate header file.
OK, I will create the sh_spi.h file.
>> +static void sh_spi_write(unsigned long data, unsigned long offset)
>> +{
>> + writel(data, CONFIG_SH_SPI_BASE + offset);
>
> NAK. We do not allow the base + offset notation. Pleaseuse a proper
> C struct instead.
>
> Please fix globally.
Yes, I will fix the driver.
Best regards,
Yoshihiro Shimoda
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
