> -----Original Message----- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Wednesday, January 19, 2011 6:33 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Gala Kumar-B11780 > Subject: Re: [U-Boot] [PATCH] Net: Add Intel E1000 82574L PCIe card support > > Dear Roy Zang, > > In message <1295351719-2687-1-git-send-email-tie-fei.z...@freescale.com> you > wrote: > > Add Intel E1000 82574L PCIe card support. Test on MPC8544DS > > and MPC8572 board. > > Add the missing contact information for future support. > > > > Signed-off-by: Roy Zang <tie-fei.z...@freescale.com> > > --- [snip]
> > diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h > > index eb0804b..4c60b70 100644 > > --- a/drivers/net/e1000.h > > +++ b/drivers/net/e1000.h > > @@ -24,12 +24,18 @@ > > Linux NICS <linux.n...@intel.com> > > Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497 > > > > + > > > ****************************************************************************** > */ > > Please drop the additional blank line > > > +/* Copyright 2009, 2011 Freescale Semiconductor, Inc. > > + * Authors: Roy Zang <tie-fei.z...@freescale.com> > > + * - Add PCI Express card support in Jul. 2009 > > + */ > > If you really insist on adding this, thenmove it up into the header. In fact, my original internal code put it to the header, but when I check it with checkpatch.pl, I will get a warning such as: WARNING: please, no spaces at the start of a line #156: FILE: drivers/net/e1000.h:5: + Copyright 2011 Freescale Semiconductor, Inc.$ How to balance? Thanks. Roy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
