On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov
<alexey...@postmarketos.org> wrote:
>
> Now that reg-names is required, specify them, and use correct
> addresses for SPMI arbiter regs, taken from Linux dts [1] [2].
>
> [1]
> https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/qcs404.dtsi#L739
> [2]
> https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/sdm845.dtsi#L4896
>
Since you have already aligned the u-boot driver to work with Linux DT
binding, we should rather exactly match spmi DT nodes as in Linux dts
files.
-Sumit
> Signed-off-by: Alexey Minnekhanov <alexey...@postmarketos.org>
> ---
> arch/arm/dts/qcs404-evb.dts | 7 ++++---
> arch/arm/dts/sdm845.dtsi | 8 ++++----
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/dts/qcs404-evb.dts b/arch/arm/dts/qcs404-evb.dts
> index 0639af8fe336..6bf6736139ed 100644
> --- a/arch/arm/dts/qcs404-evb.dts
> +++ b/arch/arm/dts/qcs404-evb.dts
> @@ -171,9 +171,10 @@
>
> spmi@200f000 {
> compatible = "qcom,spmi-pmic-arb";
> - reg = <0x200f000 0x1000
> - 0x2400000 0x400000
> - 0x2c00000 0x400000>;
> + reg = <0x0200f000 0x1000>,
> + <0x0200a000 0x2100>,
> + <0x02c00000 0x800000>;
> + reg-names = "core", "cnfg", "obsrvr";
> #address-cells = <0x1>;
> #size-cells = <0x1>;
>
> diff --git a/arch/arm/dts/sdm845.dtsi b/arch/arm/dts/sdm845.dtsi
> index 607af277f8be..2bb0954133c5 100644
> --- a/arch/arm/dts/sdm845.dtsi
> +++ b/arch/arm/dts/sdm845.dtsi
> @@ -65,10 +65,10 @@
>
> spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> - reg = <0xc440000 0x1100>,
> - <0xc600000 0x2000000>,
> - <0xe600000 0x100000>;
> - reg-names = "cnfg", "core", "obsrvr";
> + reg = <0x0c440000 0x1100>,
> + <0x0c40a000 0x26000>,
> + <0x0e600000 0x100000>;
> + reg-names = "core", "cnfg", "obsrvr";
> #address-cells = <0x1>;
> #size-cells = <0x1>;
>
> --
> 2.38.2
>
