Dear Lei Wen, In message <1294754710-7834-3-git-send-email-lei...@marvell.com> you wrote: > Pantheon Family processors are highly integrated SoCs > based on Sheeva_88SV331x-v5 PJ1 cpu core. > Ref: > http://www.marvell.com/products/processors/communications/marvell_pantheon_910_920_pb.pdf ... > +/* For preventing risk of instability in reading counter value, > + * first set read request to register cvwr and then read same > + * register after it captures counter value. > + */
Incorrect multiline comment style. Please fix globally. > +ulong read_timer(void) > +{ > + struct panthtmr_registers *panthtimers = > + (struct panthtmr_registers *) PANTHEON_TIMER_BASE; > + volatile int loop=100; > + > + writel(COUNT_RD_REQ, &panthtimers->cvwr); > + while (loop--); Please write this as while (loop--) ; Please fix globally. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Q: Why do mountain climbers rope themselves together? A: To prevent the sensible ones from going home. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot