On Fri, Nov 25, 2022 at 12:56:29PM +0100, Patrick Delaunay wrote:
> In scmi firmware driver, it is better to bind the scmi protocol driver
> "scmi_voltage_domain" with the node name of the protocol 17 and not
> the sub-node named "regulator", because is a fixed string which doesn't
> provide information and because it is not aligned with the other scmi
> protocol nodes.
>
> For example on stm32mp135f-dk board with device tree in stm32mp131.dtsi
>
> scmi: scmi {
> compatible = "linaro,scmi-optee";
> #address-cells = <1>;
> #size-cells = <0>;
> linaro,optee-channel-id = <0>;
> shmem = <&scmi_shm>;
> scmi_clk: protocol@14 {
> reg = <0x14>;
> #clock-cells = <1>;
> };
> scmi_reset: protocol@16 {
> reg = <0x16>;
> #reset-cells = <1>;
> };
> scmi_voltd: protocol@17 {
> reg = <0x17>;
> scmi_regu: regulators {
> #address-cells = <1>;
> #size-cells = <0>;
> scmi_reg11: voltd-reg11 {
> reg = <VOLTD_SCMI_REG11>;
> regulator-name = "reg11";
> };
> scmi_reg18: voltd-reg18 {
> reg = <VOLTD_SCMI_REG18>;
> regulator-name = "reg18";
> };
> scmi_usb33: voltd-usb33 {
> reg = <VOLTD_SCMI_USB33>;
> regulator-name = "usb33";
> };
> };
> };
> };
>
> Before the patch:
>
> > dm tree
>
> scmi_agent 0 [ + ] scmi-over-optee |-- scmi
> clk 1 [ + ] scmi_clk | |-- protocol@14
> ...
> reset 1 [ ] scmi_reset_domain | |-- protocol@16
> nop 2 [ + ] scmi_voltage_domain | `-- regulators
> regulator 0 [ + ] scmi_regulator | |-- voltd-reg11
> regulator 1 [ + ] scmi_regulator | |-- voltd-reg18
> regulator 2 [ + ] scmi_regulator | |-- voltd-usb33
> ...
>
> after the patch:
>
> > dm tree
>
> scmi_agent 0 [ + ] scmi-over-optee |-- scmi
> clk 1 [ + ] scmi_clk | |-- protocol@14
> ...
> reset 1 [ ] scmi_reset_domain | |-- protocol@16
> nop 2 [ + ] scmi_voltage_domain | `-- protocol@17
> regulator 0 [ + ] scmi_regulator | |-- voltd-reg11
> regulator 1 [ + ] scmi_regulator | |-- voltd-reg18
> regulator 2 [ + ] scmi_regulator | |-- voltd-usb33
> ...
>
> Signed-off-by: Patrick Delaunay <patrick.delau...@foss.st.com>Applied to u-boot/next, thanks! -- Tom
signature.asc
Description: PGP signature
