Thank you for your suggestions. The next patch will be modified according to
your suggestions.
Thanks,
Pengfei Fan
2022-12-05 05:17:05 "Simon Glass" <s...@chromium.org> 写道：
> On Sat, 3 Dec 2022 at 01:26, Pengfei Fan <fanpengf...@eswincomputing.com>
> wrote:
> >
> > Fix some typos in spi drivers
> >
> > Signed-off-by: Pengfei Fan <fanpengf...@eswincomputing.com>
> > ---
> > drivers/spi/bcm63xx_hsspi.c | 2 +-
> > drivers/spi/cadence_qspi.c | 2 +-
> > drivers/spi/fsl_dspi.c | 4 ++--
> > drivers/spi/mtk_snfi_spi.c | 4 ++--
> > drivers/spi/mvebu_a3700_spi.c | 2 +-
> > drivers/spi/omap3_spi.c | 2 +-
> > drivers/spi/rk_spi.c | 2 +-
> > drivers/spi/sh_qspi.c | 2 +-
> > drivers/spi/spi-aspeed-smc.c | 4 ++--
> > drivers/spi/spi-qup.c | 2 +-
> > drivers/spi/spi-sifive.c | 2 +-
> > 11 files changed, 14 insertions(+), 14 deletions(-)
>
> Reviewed-by: Simon Glass <s...@chromium.org>
>
> [..]
>
> > diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
> > index 5ba8a8ea79..23af77f3df 100644
> > --- a/drivers/spi/sh_qspi.c
> > +++ b/drivers/spi/sh_qspi.c
> > @@ -160,7 +160,7 @@ static int sh_qspi_xfer_common(struct sh_qspi_slave
> > *ss, unsigned int bitlen,
> > }
> >
> > if (bitlen % 8) {
> > - printf("%s: bitlen is not 8bit alined %d", __func__,
> > bitlen);
> > + printf("%s: bitlen is not 8bit aligned %d", __func__,
> > bitlen);
> > return 1;
> > }
> >
>
> But we should not be using __func__. Better:
>
> log_warning("bitlen is not 8bit aligned %d", bitlen);
>
> Also need to put this at the very top of the file:
>
> #define LOG_CATEGORY UCLASS_SPI
>
> Regards,
> Simon
