Hi
On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros <rog...@kernel.org> wrote:
>
> Allocate omap_ecclayout on the heap as we have
> limited .bss space on AM64 R5 SPL configuration.
>
> Reduces .bss usage by 2984 bytes.
>
> Signed-off-by: Roger Quadros <rog...@kernel.org>
> ---
> drivers/mtd/nand/raw/omap_gpmc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/omap_gpmc.c
> b/drivers/mtd/nand/raw/omap_gpmc.c
> index b5ad66ad49..e772a914c8 100644
> --- a/drivers/mtd/nand/raw/omap_gpmc.c
> +++ b/drivers/mtd/nand/raw/omap_gpmc.c
> @@ -40,7 +40,6 @@ static u8 bch8_polynomial[] = {0xef, 0x51, 0x2e, 0x09,
> 0xed, 0x93, 0x9a, 0xc2,
> 0x97, 0x79, 0xe5, 0x24, 0xb5};
> #endif
> static uint8_t cs_next;
> -static __maybe_unused struct nand_ecclayout omap_ecclayout;
>
> #if defined(CONFIG_NAND_OMAP_GPMC_WSCFG)
> static const int8_t wscfg[CONFIG_SYS_MAX_NAND_DEVICE] =
> @@ -874,7 +873,7 @@ static void __maybe_unused omap_free_bch(struct mtd_info
> *mtd)
> static int omap_select_ecc_scheme(struct nand_chip *nand,
> enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int
> oobsize) {
> struct omap_nand_info *info =
> nand_get_controller_data(nand);
> - struct nand_ecclayout *ecclayout = &omap_ecclayout;
> + struct nand_ecclayout *ecclayout = nand->ecc.layout;
> int eccsteps = pagesize / SECTOR_BYTES;
> int i;
>
> @@ -1167,7 +1166,9 @@ int board_nand_init(struct nand_chip *nand)
> nand->cmd_ctrl = omap_nand_hwcontrol;
> nand->options |= NAND_NO_PADDING | NAND_CACHEPRG;
> nand->chip_delay = 100;
> - nand->ecc.layout = &omap_ecclayout;
> + nand->ecc.layout = kzalloc(sizeof(*nand->ecc.layout), GFP_KERNEL);
> + if (!nand->ecc.layout)
> + return -ENOMEM;
>
> /* configure driver and controller based on NAND device bus-width */
> gpmc_config = readl(&gpmc_cfg->cs[cs].config1);
> --
> 2.17.1
>
Reviewed-By: Michael Trimarchi <mich...@amarulasolutions.com>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com
