Re: [PATCH] treewide: Remove the unnecessary space before semicolon

Stefan Roese Tue, 25 Oct 2022 21:54:40 -0700

On 26.10.22 06:40, Bin Meng wrote:

%s/return ;/return;


Signed-off-by: Bin Meng <bm...@tinylab.org>
---

  arch/powerpc/cpu/mpc85xx/cpu_init.c       | 2 +-
  arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 2 +-
  arch/powerpc/cpu/mpc85xx/fdt.c            | 6 +++---
  arch/powerpc/cpu/mpc85xx/liodn.c          | 4 ++--
  arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c | 2 +-
  arch/powerpc/cpu/mpc85xx/portals.c        | 8 ++++----
  arch/powerpc/cpu/mpc85xx/tlb.c            | 2 +-
  arch/powerpc/cpu/mpc8xxx/fdt.c            | 2 +-
  arch/powerpc/cpu/mpc8xxx/law.c            | 2 +-
  arch/powerpc/lib/bootm.c                  | 4 ++--
  board/ti/evm/evm.c                        | 2 +-
  drivers/ddr/fsl/util.c                    | 2 +-
  drivers/net/fm/init.c                     | 4 ++--
  13 files changed, 21 insertions(+), 21 deletions(-)


Nice.

Reviewed by: Stefan Roese <s...@denx.de>

Thanks,
Stefan

diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c 
b/arch/powerpc/cpu/mpc85xx/cpu_init.c
index 92a7e608ce..90f024d0a7 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c
@@ -446,7 +446,7 @@ ulong cpu_init_f(void)
  /* Implement a dummy function for those platforms w/o SERDES */
  static void __fsl_serdes__init(void)
  {
-       return ;
+       return;
  }
  __attribute__((weak, alias("__fsl_serdes__init"))) void fsl_serdes_init(void);

diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c

index 1bba216371..e6347cfd2d 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
@@ -76,7 +76,7 @@ void setup_ifc(void)
        ifc_out32(&(ifc_regs.gregs->csor_cs[0].csor), CONFIG_SYS_CSOR0);
        ifc_out32(&(ifc_regs.gregs->amask_cs[0].amask), CONFIG_SYS_AMASK0);

- return ;

+       return;
  }
  #endif

diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c

index c8ad6a1b01..61d8aa7f4c 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -271,13 +271,13 @@ static inline void ft_fixup_l2cache(void *blob)

if (ph == NULL) {

                debug("no next-level-cache property\n");
-               return ;
+               return;
        }

off = fdt_node_offset_by_phandle(blob, *ph);

        if (off < 0) {
                printf("%s: %s\n", __func__, fdt_strerror(off));
-               return ;
+               return;
        }

ft_fixup_l2cache_compatible(blob, off);

@@ -373,7 +373,7 @@ next:
                l3_off = fdt_node_offset_by_phandle(blob, l3_off);
                if (l3_off < 0) {
                        printf("%s: %s\n", __func__, fdt_strerror(off));
-                       return ;
+                       return;
                }
                ft_fixup_l3cache(blob, l3_off);
        }
diff --git a/arch/powerpc/cpu/mpc85xx/liodn.c b/arch/powerpc/cpu/mpc85xx/liodn.c
index a084002494..34974c92bd 100644
--- a/arch/powerpc/cpu/mpc85xx/liodn.c
+++ b/arch/powerpc/cpu/mpc85xx/liodn.c
@@ -111,7 +111,7 @@ static void setup_fman_liodn_base(enum fsl_dpaa_dev dev,
  #endif
        default:
                printf("Error: Invalid device type to %s\n", __FUNCTION__);
-               return ;
+               return;
        }

base = (liodn_bases[dev].id[0] << 16) | liodn_bases[dev].id[0];

@@ -232,7 +232,7 @@ static void fdt_fixup_srio_liodn(void *blob, struct 
srio_liodn_id_table *tbl)
        /* search for srio node, if doesn't exist just return - nothing todo */
        srio_off = fdt_node_offset_by_compatible(blob, -1, "fsl,srio");
        if (srio_off < 0)
-               return ;
+               return;

for (i = 0; i < srio_liodn_tbl_sz; i++) {

                int off, portid = tbl[i].portid;
diff --git a/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c 
b/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c
index 2a5c3e3200..38f30afdfc 100644
--- a/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c
+++ b/arch/powerpc/cpu/mpc85xx/mpc8548_serdes.c
@@ -45,7 +45,7 @@ void fsl_serdes_init(void)

if (srds1_cfg >= ARRAY_SIZE(serdes1_cfg_tbl)) {

                printf("Invalid PORDEVSR[IO_SEL] = %d\n", srds1_cfg);
-               return ;
+               return;
        }

for (lane = 0; lane < SRDS1_MAX_LANES; lane++) {

diff --git a/arch/powerpc/cpu/mpc85xx/portals.c 
b/arch/powerpc/cpu/mpc85xx/portals.c
index 52e2124fb9..6b4cbddcdf 100644
--- a/arch/powerpc/cpu/mpc85xx/portals.c
+++ b/arch/powerpc/cpu/mpc85xx/portals.c
@@ -21,7 +21,7 @@ void fdt_portal(void *blob, const char *compat, const char 
*container,

off = fdt_node_offset_by_compatible(blob, -1, compat);

        if (off < 0)
-               return ;
+               return;

off = fdt_parent_offset(blob, off);

        /* if non-zero assume we have a container */
@@ -35,7 +35,7 @@ void fdt_portal(void *blob, const char *compat, const char 
*container,
                range = fdt_getprop_w(blob, off, "ranges", &len);
                if (range == NULL) {
                        printf("ERROR: container for %s has no ranges", compat);
-                       return ;
+                       return;
                }

range[0] = 0;

@@ -61,13 +61,13 @@ void fdt_portal(void *blob, const char *compat, const char 
*container,
                if (container && (memcmp(container, name, len))) {
                        printf("WARNING: container names didn't match %s %s\n",
                                container, name);
-                       return ;
+                       return;
                }

memcpy(&buf, name, len);

                len += sprintf(&buf[len], "@%llx", addr);
                fdt_set_name(blob, off, buf);
-               return ;
+               return;
        }

printf("ERROR: %s isn't in a container. Not supported\n", compat);

diff --git a/arch/powerpc/cpu/mpc85xx/tlb.c b/arch/powerpc/cpu/mpc85xx/tlb.c
index e39fe14382..81e60722f9 100644
--- a/arch/powerpc/cpu/mpc85xx/tlb.c
+++ b/arch/powerpc/cpu/mpc85xx/tlb.c
@@ -41,7 +41,7 @@ __weak void init_tlbs(void)
                          tlb_table[i].mas7);
        }

- return ;

+       return;
  }

#if !defined(CONFIG_NAND_SPL) && \

diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c
index 871554a7f4..3004290248 100644
--- a/arch/powerpc/cpu/mpc8xxx/fdt.c
+++ b/arch/powerpc/cpu/mpc8xxx/fdt.c
@@ -128,7 +128,7 @@ void ft_srio_setup(void *blob)
        /* search for srio node, if doesn't exist just return - nothing todo */
        srio_off = fdt_node_offset_by_compatible(blob, -1, "fsl,srio");
        if (srio_off < 0)
-               return ;
+               return;

#ifdef CONFIG_SRIO1

        if (is_serdes_configured(SRIO1))
diff --git a/arch/powerpc/cpu/mpc8xxx/law.c b/arch/powerpc/cpu/mpc8xxx/law.c
index 198b5b10a5..24bbe3b45f 100644
--- a/arch/powerpc/cpu/mpc8xxx/law.c
+++ b/arch/powerpc/cpu/mpc8xxx/law.c
@@ -353,5 +353,5 @@ void init_laws(void)
        }
  #endif

- return ;

+       return;
  }
diff --git a/arch/powerpc/lib/bootm.c b/arch/powerpc/lib/bootm.c
index 512787854c..8ae8d8a3e7 100644
--- a/arch/powerpc/lib/bootm.c
+++ b/arch/powerpc/lib/bootm.c
@@ -113,7 +113,7 @@ static void boot_jump_linux(struct bootm_headers *images)
                           cmd_start, cmd_end, 0, 0);
                /* does not return */
        }
-       return ;
+       return;
  }

void arch_lmb_reserve(struct lmb *lmb)

@@ -148,7 +148,7 @@ void arch_lmb_reserve(struct lmb *lmb)
        cpu_mp_lmb_reserve(lmb);
  #endif

- return ;

+       return;
  }

static void boot_prep_linux(struct bootm_headers *images)

diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c
index 39b5c706a9..a7f9a7eca1 100644
--- a/board/ti/evm/evm.c
+++ b/board/ti/evm/evm.c
@@ -234,7 +234,7 @@ static void reset_net_chip(void)
        ret = gpio_request(rst_gpio, "");
        if (ret < 0) {
                printf("Unable to get GPIO %d\n", rst_gpio);
-               return ;
+               return;
        }

/* Configure as output */

diff --git a/drivers/ddr/fsl/util.c b/drivers/ddr/fsl/util.c
index 43cb01804b..589d7df731 100644
--- a/drivers/ddr/fsl/util.c
+++ b/drivers/ddr/fsl/util.c
@@ -147,7 +147,7 @@ __fsl_ddr_set_lawbar(const common_timing_params_t 
*memctl_common_params,
        if (set_ddr_laws(base, size, law_memctl) < 0) {
                printf("%s: ERROR (ctrl #%d, TRGT ID=%x)\n", __func__, ctrl_num,
                        law_memctl);
-               return ;
+               return;
        }
        debug("setup ddr law base = 0x%llx, size 0x%llx, TRGT_ID 0x%x\n",
                base, size, law_memctl);
diff --git a/drivers/net/fm/init.c b/drivers/net/fm/init.c
index af94dabe29..43d2000d24 100644
--- a/drivers/net/fm/init.c
+++ b/drivers/net/fm/init.c
@@ -149,7 +149,7 @@ void fman_enet_init(void)
                }
        }

- return ;

+       return;
  }

void fm_disable_port(enum fm_port port)

@@ -233,7 +233,7 @@ static void
  __def_board_ft_fman_fixup_port(void *blob, char * prop, phys_addr_t pa,
                                enum fm_port port, int offset)
  {
-       return ;
+       return;
  }

void board_ft_fman_fixup_port(void *blob, char * prop, phys_addr_t pa,


Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

Reply via email to