Re: [PATCH v3 2/8] imxrt1020: fix lpuart issue in common u-boot device tree

[Giulio Benetti]

Hi Marcel,

thanks for contributing,

Il 22/10/2022 23:42, Marcel Ziswiler ha scritto:

From: Marcel Ziswiler <marcel.ziswi...@toradex.com>

Fix lpuart issue in common U-Boot device tree.

There's no need to repeat in commit log the subject.

Signed-off-by: Marcel Ziswiler <marcel.ziswi...@toradex.com>
---

(no changes since v1)

  arch/arm/dts/imxrt1020-evk-u-boot.dtsi | 7 ++++---
  arch/arm/dts/imxrt1020-evk.dts         | 1 -
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi 
b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi
index 9e1b074d2e..7cab486f5f 100644
--- a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi
+++ b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi
@@ -67,9 +67,6 @@

imxrt1020-evk {

                u-boot,dm-spl;
-               pinctrl_lpuart1: lpuart1grp {
-                       u-boot,dm-spl;
-               };

pinctrl_semc: semcgrp {

                        u-boot,dm-spl;
@@ -81,6 +78,10 @@
        };
  };

+&pinctrl_lpuart1 {

+       u-boot,dm-spl;
+};
+

I don't understand the goal of this change, can you elaborate?
As I remember pinctrl_lpuart1 already works correctly. The same goes
for:
pinctrl_semc
pinctrl_usdhc0

So you're not fixing something.

  &usdhc1 {
        u-boot,dm-spl;
  };
diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk.dts
index 22ae5ed735..d4d1de4ea8 100644
--- a/arch/arm/dts/imxrt1020-evk.dts
+++ b/arch/arm/dts/imxrt1020-evk.dts
@@ -6,7 +6,6 @@

/dts-v1/;

  #include "imxrt1020.dtsi"
-#include "imxrt1020-evk-u-boot.dtsi"

This ^^^ is needed, please revert it.

  #include "imxrt1020-pinfunc.h"

/ {

Have you also tested the change on a board?

Best regards
--
Giulio Benetti
CEO/CTO@Benetti Engineering sas